Hi Qianfan, On Tue, 28 Dec 2021 at 20:05, qianfan <[email protected]> wrote: > > > 在 2021/12/28 16:52, Simon Glass 写道: > > Hi Qianfan, > > > > +Anatolij Gustschin > > > > On Mon, 20 Dec 2021 at 18:22, qianfan <[email protected]> wrote: > >> Hi: > >> > >> I had tested 'bmp display' command with 24bits bmp picture, > >> **video_bmp_display** function always convert 24bits picture to RGB555 > >> format if the lcd is 16bits. But most of all lcd controller is RGB565 > >> format. Should we improve this? > > See also: > > > > https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/ > > Hi, I read this patch and it is resolved this question. But I don't know > if it is a good idea that just replace RGB555 to RGB565. > > Maybe somedays after this patch merged, someone will complain about > video_bmp_display doesn't support RGB555 mode.
Maybe, at which point it should really become an option. But you did say that 565 is more common. The existing BPP enum is not really descriptive enough. Regards, Simon

