Hi Heinrich, On Fri, 21 Jan 2022 at 09:03, Heinrich Schuchardt <[email protected]> wrote: > > On 1/21/22 16:20, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > <[email protected]> wrote: > >> > >> Use "%pS" to print text representations of GUIDs. > >> > >> Signed-off-by: Heinrich Schuchardt <[email protected]> > >> --- > >> cmd/efidebug.c | 160 ++--------------------------------------- > >> include/efi_api.h | 8 +++ > >> include/efi_dt_fixup.h | 4 -- > >> include/efi_rng.h | 4 -- > >> lib/uuid.c | 116 ++++++++++++++++++++++++++++++ > >> 5 files changed, 128 insertions(+), 164 deletions(-) > >> > > > > Does this blow up the image size? These strings only in the debug side > > before. > > It was to avoid image size increase that I added > +#ifdef CONFIG_CMD_EFIDEBUG
Ah yes, thanks. Reviewed-by: Simon Glass <[email protected]> > > > > > Having said that, I would much rather see a string than a guid, which > > I consider to be little more than an obfuscation. > > That was my motivation. When debugging a boot failure I set DEBUG in > lib/efi_loader/efi_boottime.c and reading GUIDs in the debug output was > not helpful. Indeed. Regards, SImon
