Hi Heinrich, On Mon, 24 Jan 2022 at 21:21, Heinrich Schuchardt <[email protected]> wrote: > > On 1/22/22 02:16, Simon Glass wrote: > > When we have the block descriptor we can simply access the device. Drop > > the unnecessary function call. > > > > Signed-off-by: Simon Glass <[email protected]> > > --- > > > > lib/efi_loader/efi_device_path.c | 14 ++------------ > > 1 file changed, 2 insertions(+), 12 deletions(-) > > > > diff --git a/lib/efi_loader/efi_device_path.c > > b/lib/efi_loader/efi_device_path.c > > index a838a32b810..f415741d528 100644 > > --- a/lib/efi_loader/efi_device_path.c > > +++ b/lib/efi_loader/efi_device_path.c > > @@ -768,13 +768,8 @@ __maybe_unused static void *dp_fill(void *buf, struct > > udevice *dev) > > static unsigned dp_part_size(struct blk_desc *desc, int part) > > { > > unsigned dpsize; > > - struct udevice *dev; > > - int ret; > > + struct udevice *dev = desc->bdev; > > drivers/block/blk_legacy.c still exists but it does not set bdev. > CONFIG_EFI_LOADER does not require CONFIG_BLK.
It depends on BLK. Where are you looking? > > Are all non-DM block devices eliminated by now? No, but they are all way out of date and we should probably remove them. Regards, Simon
