On Fri, 2022-02-04 at 23:25 -0300, Fabio Estevam wrote: > Hi Marcel, > > On Fri, Feb 4, 2022 at 7:17 PM Marcel Ziswiler <[email protected]> wrote: > > > +#if 0 > > +int board_phys_sdram_size(phys_size_t *bank1_size, phys_size_t *bank2_size) > > Please remove this unused function.
Yes, this is left for after basic support got applied and I can work on properly supporting dynamic memory sizing on the i.MX 8M Plus as well. > > diff --git a/doc/board/toradex/verdin-imx8mm.rst > > b/doc/board/toradex/verdin-imx8mm.rst > > index a11c82da2f..917bea82b7 100644 > > --- a/doc/board/toradex/verdin-imx8mm.rst > > +++ b/doc/board/toradex/verdin-imx8mm.rst > > The changes in this file should better be in a separate patch. Yes, good catch. That one really slipped in. I will remove it again in a v4. > Reviewed-by: Fabio Estevam <[email protected]> Thanks, Fabio.
