Hi Fabio, Can you help test these 3 patches on imx6qdl-pico board or imx7s board on your side to double check whether these patches enlarge the total boot time?
Best Regards Bough Chen > -----Original Message----- > From: Marek Vasut [mailto:[email protected]] > Sent: 2022年2月14日 5:53 > To: Bough Chen <[email protected]>; Peng Fan <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Cc: dl-uboot-imx <[email protected]> > Subject: Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use > VENDORSPEC_FRC_SDCLK_ON when necessary > > On 2/11/22 12:16, [email protected] wrote: > > Hi, > > [...] > > > @@ -897,6 +900,11 @@ static int fsl_esdhc_execute_tuning(struct udevice > *dev, uint32_t opcode) > > > > esdhc_stop_tuning(mmc); > > > > + /* change to default setting, let host control the card clock */ > > + esdhc_clrbits32(®s->vendorspec, VENDORSPEC_FRC_SDCLK_ON); > > + if (readx_poll_timeout(esdhc_read32, ®s->prsstat, tmp, tmp & > PRSSTAT_SDOFF, 100)) > > Please propagate the error in both cases: > > ret = readx_poll..(); > if (ret) > dev_warn(...); > > return ret; > > > + pr_warn("fsl_esdhc_imx: card clock not gate off as expect.\n"); > > btw. s@gate@gated@ , s@expect@expected@ (past tense) > > With those small details fixed: > > Reviewed-by: Marek Vasut <[email protected]>
smime.p7s
Description: S/MIME cryptographic signature
