Le Wed, 9 Mar 2022 09:45:01 +0000,
<eugen.hris...@microchip.com> a écrit :
> On 3/9/22 11:22 AM, Clément Léger wrote:
> > When using interrupts property, a global interrupt controller needs to
> > be added to avoid warnings when compiling device-tree:
> >
> > arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property):
> > /ahb/apb/timer@f800c000: Missing interrupt-parent
> >
> > Add AIC node as the sama5d2 global interrupt controller.
> >
> > Signed-off-by: Clément Léger <clement.le...@bootlin.com>
> > ---
> > arch/arm/dts/sama5d2.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> > index 038cd73c03..1904f16eb6 100644
> > --- a/arch/arm/dts/sama5d2.dtsi
> > +++ b/arch/arm/dts/sama5d2.dtsi
> > @@ -3,6 +3,7 @@
> > / {
> > model = "Atmel SAMA5D2 family SoC";
> > compatible = "atmel,sama5d2";
> > + interrupt-parent = <&aic>;
> >
> > aliases {
> > spi0 = &spi0;
> > @@ -762,6 +763,15 @@
> > status = "disabled";
> > };
> >
> > + aic: interrupt-controller@fc020000 {
> > + compatible = "atmel,sama5d2-aic";
> > + reg = <0xfc020000 0x200>;
> > + #interrupt-cells = <3>;
> > + interrupt-controller;
> > + atmel,external-irqs = <49>;
> > + status = "disabled";
> > + };
>
> Hello Clement,
>
> Any reason to not use the exact node from Linux ?
I wanted it to match all the existing nodes that are already in
this file (ie compatible, then regs and so on), it seems more coherent.
>
> aic: interrupt-controller@fc020000 {
> #interrupt-cells = <3>;
>
> compatible = "atmel,sama5d2-aic";
>
> interrupt-controller;
>
> reg = <0xfc020000 0x200>;
>
> atmel,external-irqs = <49>;
>
> };
>
> I would like to avoid any difference between Uboot and Linux, unless
> really required.
If you want, I can reuse the exact same definition used by Linux of
course.
>
> Don't worry if the node is enabled, it's no problem with that. It won't
> be probed due to several reasons: no driver and no need for it, since
> Uboot is based on lazy probing.
Ok.
>
> Eugen
>
> > +
> > i2c1: i2c@fc028000 {
> > compatible = "atmel,sama5d2-i2c";
> > reg = <0xfc028000 0x100>;
> > --
> > 2.34.1
> >
>
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
