On Thu, Mar 3, 2022 at 9:55 AM Ramon Fried <[email protected]> wrote: > > On Wed, Mar 2, 2022 at 3:58 AM Adam Ford <[email protected]> wrote: > > > > On Tue, Mar 1, 2022 at 2:38 PM Joe Hershberger <[email protected]> > > wrote: > > > > > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey <[email protected]> wrote: > > > > > > > > When gpio_request_by_name allocates a gpio output it by default will > > > > de-assert the gpio which for phy-reset will take the PHY out of reset. > > > > As this occurs before fec_gpio_reset is called to assert the reset > > > > line it can cause undesired affects if reset timings are not properly > > > > met. > > > > > > > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > > > > (reset asserted) to avoid this. > > > > > > > > Cc: Sean Anderson <[email protected]> > > > > Signed-off-by: Tim Harvey <[email protected]> > > > > > > Acked-by: Joe Hershberger <[email protected]> > > > > Tested-by: Adam Ford <[email protected]> #imx8mm-beacon > Reviewed-by: Ramon Fried <[email protected]> Applied to u-boot-net/next Thanks, Ramon
