On Tue, Apr 12, 2022 at 07:09:24AM -0300, Fabio Estevam wrote: > Hi Peng, > > Thanks for reworking this series. > > On Tue, Apr 12, 2022 at 12:33 AM Peng Fan (OSS) <[email protected]> wrote: > > > > From: Peng Fan <[email protected]> > > > > Enable CONFIG_DM_SERIAL. uart2 and its pinmux was already > > marked with u-boot,dm-spl. > > > > File generated with make savedefconfig > > IMHO, running savedefconfig in the same patch makes it more confusing > to review it. > > My understanding is that Tom generates savedefconfig for each > defconfig via script. > > Tom, is this correct? > > Also, you missed your Signed-off-by line.
Yes, extra changes in the defconfig should be avoided. For larger series what I'll do locally is run tools/moveconfig.py -sC, then the migrations, and then discard the resync commit when posting (as it rarely matters). For smaller series like this, just edit the patch before sending to omit the hunks. It's not a huge deal either way to me since I'll just re-sync the configs if the patch doesn't apply cleanly. -- Tom
signature.asc
Description: PGP signature
