Hi Michael,

On 4/19/22 7:26 PM, Michael Walle wrote:
Hi Sean,

This adds an SFP binding for the processors it is present on. I have
only tested this for the LS1046A.

Signed-off-by: Sean Anderson <sean.ander...@seco.com>

There is an upstream binding
Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml

I see it will be added in 5.18, neat.

Are you aware of that?

I am now.

Could you submit a patch there to add your new compatibles?

Sure. I didn't know there was an upstream binding, but I'll try and add these 
properties.

Esp. because you are using a clock which
isn't described in the upstream binding. I'm curious, do you need the
clock? I only know the LS1028A and it seems you don't have to turn on
any clock there. It might also be the case I've missed something.

You need the clock to set the programming duration properly. See the probe
function for this driver. For read-only access, it is not necessary.

--Sean

Reply via email to