On Tue, May 10, 2022 at 12:43:40PM -0400, Sean Anderson wrote:
> Hi Tom,
> 
> On 5/10/22 11:08 AM, Tom Rini wrote:
> > We have many cases of SPL (or TPL or VPL) drivers that don't depend on
> > SPL_MISC (and so on) but rather just MISC.
> > 
> > Signed-off-by: Tom Rini <[email protected]>
> > ---
> >  drivers/misc/Kconfig | 34 +++++++++++++++++++++++-----------
> >  1 file changed, 23 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index c829939622b0..ebe84b15a49a 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -115,7 +115,7 @@ config CROS_EC
> >  
> >  config SPL_CROS_EC
> >     bool "Enable Chrome OS EC in SPL"
> > -   depends on SPL
> > +   depends on SPL && SPL_MISC
> 
> Can't we just depend on SPL_MISC?

Yes and..

> 
> --Sean
> 
> >     help
> >       Enable access to the Chrome OS EC in SPL. This is a separate
> >       microcontroller typically available on a SPI bus on Chromebooks. It
> > @@ -125,7 +125,7 @@ config SPL_CROS_EC
> >  
> >  config TPL_CROS_EC
> >     bool "Enable Chrome OS EC in TPL"
> > -   depends on TPL
> > +   depends on TPL && TPL_MISC

TPL_MISC alone too.  I caught this in some places but not all, I'll
respin and check for others.  Thanks!

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to