On 24/05/2022 11:00, Peng Fan (OSS) wrote: > From: Peng Fan <[email protected]> > > We are migrating to use BINMAN SYMBOLS, the current name is not > a valid binman type, so update to unify them.
'not a valid binman type, so' here is misleading. Names do not need to be binman types if you have the 'type' property. 'the current names are inconsistent across different boards, so' would be better. > Also add `type = "blob-ext";` for generating a valid binman symbol The 'type' doesn't matter for symbol generation. '... since the new names are not valid binman types' is the real reason. > Tested-by: Tim Harvey <[email protected]> #imx8m[m,n,p]-venice > Signed-off-by: Peng Fan <[email protected]> > --- > arch/arm/dts/imx8mm-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mn-beacon-kit-u-boot.dtsi | 12 ++++++++---- > arch/arm/dts/imx8mn-bsh-smm-s2-u-boot-common.dtsi | 4 ++-- > arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 12 ++++++++---- > arch/arm/dts/imx8mn-evk-u-boot.dtsi | 12 ++++++++---- > arch/arm/dts/imx8mn-var-som-symphony-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mn-venice-u-boot.dtsi | 8 ++++---- > arch/arm/dts/imx8mp-u-boot.dtsi | 12 ++++++++---- > arch/arm/dts/imx8mq-cm-u-boot.dtsi | 12 ++++++++---- > arch/arm/dts/imx8mq-u-boot.dtsi | 8 ++++---- > 10 files changed, 58 insertions(+), 38 deletions(-) > > diff --git a/arch/arm/dts/imx8mm-u-boot.dtsi b/arch/arm/dts/imx8mm-u-boot.dtsi > index 9f66cdb65a9..dc036894d82 100644 > --- a/arch/arm/dts/imx8mm-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi > @@ -39,25 +39,25 @@ > filename = "u-boot-spl.bin"; > }; > > - 1d-imem { > + imem-1d { I suggested 'ddr-1d-imem-fw' in the diff I sent. Saying again in case you didn't notice. But these names are fine too. > filename = "lpddr4_pmu_train_1d_imem.bin"; > size = <0x8000>; > type = "blob-ext"; > }; > > [...]
