On Tue, 21 Jun 2022 at 05:38, Ryan Chen <ryan_c...@aspeedtech.com> wrote:
>
> > -----Original Message-----
> > From: joel.s...@gmail.com <joel.s...@gmail.com> On Behalf Of Joel Stanley
> > Sent: Monday, June 20, 2022 3:25 PM
> > To: Ryan Chen <ryan_c...@aspeedtech.com>; BMC-SW
> > <bmc...@aspeedtech.com>; Heiko Schocher <h...@denx.de>
> > Cc: u-boot@lists.denx.de; Cédric Le Goater <c...@kaod.org>
> > Subject: [PATCH 05/10] ARM: dts: ast2600-evb: Add I2C devices
> >
> > The EVB has an EEPROM on bus 7 and a LM75 temp sensor on bus 8. Enable
> > those busses we can test the I2C driver.
> >
> Hello,
>
> https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v5.15/arch/arm/boot/dts/aspeed-ast2600-evb.dts#L662-L687
> The eeprom is under the same bus with bus#7. Please add in bus#7.
> Bus#8 have LM75. Not have eeprom.
You're right, I've put them both one bus down.
In testing it didn't matter as the "eeprom" command doesn't use the
device tree description of the devices.
Thanks for the review, I'll send a v2.
>
> > Signed-off-by: Joel Stanley <j...@jms.id.au>
> > ---
> > arch/arm/dts/ast2600-evb.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/dts/ast2600-evb.dts b/arch/arm/dts/ast2600-evb.dts
> > index 0d650543134a..cee787ecc0eb 100644
> > --- a/arch/arm/dts/ast2600-evb.dts
> > +++ b/arch/arm/dts/ast2600-evb.dts
> > @@ -174,6 +174,11 @@
> >
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c8_default>;
> > +
> > + temp@2e {
> > + compatible = "adi,adt7490";
> > + reg = <0x2e>;
> > + };
> > };
> >
> > &i2c8 {
> > @@ -181,6 +186,12 @@
> >
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c9_default>;
> > +
> > + eeprom@50 {
> > + compatible = "atmel,24c08";
> > + reg = <0x50>;
> > + pagesize = <16>;
> > + };
> > };
> >
> > &mdio0 {
> > --
> > 2.35.1
>
