Hi Sean, > From: Sean Anderson <sean.ander...@seco.com> > Sent: Tuesday, June 28, 2022 12:57 PM > > Hi Chai, > > On 6/28/22 12:23 AM, Joel Stanley wrote: > > Hi Chai Wei, > > > > On Wed, 1 Jun 2022 at 08:21, Chia-Wei Wang > <chiawei_w...@aspeedtech.com> wrote: > >> > >> The commit b583348ca8c8 ("image: fit: Align hash output buffers") > >> places the hash output buffer at the .bss section. However, AST2600 > >> by default executes SPL in the NOR flash XIP way. This results in the > >> hash output cannot be written to the buffer as it is located at the R/X > >> only > region. > >> > >> We need to move the .bss section out of the SPL body to the DRAM > >> space, where hash output can be written to. This patch includes: > >> - Define the .bss section base and size > >> - A new SPL linker script is added with a separate .bss region specified > >> - Enable CONFIG_SPL_SEPARATE_BSS kconfig option > >> > >> Signed-off-by: Chia-Wei Wang <chiawei_w...@aspeedtech.com> > > > > This patch breaks booting for me. > > Does the patch Joel posted [1] fix your issue? It seems like I used the wrong > macro in the first place, so hopefully this patch shouldn't be necessary. > > --Sean > > [1] https://lore.kernel.org/u-boot/20220620070117.3443066-1-j...@jms.id.au/
Yes. Joel's patch also solved that issue. Relocating .bss to DRAM space can avoid similar issues. But it do create additional maintenance work. Chiawei