On 8/2/2022 10:34 PM, Billy Tsai wrote:
Hello,
On 2022/8/3, 10:10 AM, "Billy Tsai" <[email protected]> wrote:
Reviewed-by: Billy Tsai <[email protected]>
On 2022/8/3, 9:46 AM, "ChiaWei Wang" <[email protected]> wrote:
Acked-by: Chia-Wei Wang <[email protected]>
> > From: Dhananjay Phadke <[email protected]>
> > Sent: Wednesday, August 3, 2022 4:55 AM
> >
> > Ported as is, makes it easier to add readable GPIO definitions in
DTS files.
> >
> > Signed-off-by: Dhananjay Phadke <[email protected]>
> > ---
> > include/dt-bindings/gpio/aspeed-gpio.h | 49
++++++++++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> > create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
[...]
> > +
> > +#define ASPEED_GPIO(port, offset) \
> > + ((ASPEED_GPIO_PORT_##port * 8) + offset)
Please help to fix the check patch warning.
"Macro argument 'offset' may be better as '(offset)' to avoid precedence issues"
((ASPEED_GPIO_PORT_##port * 8) + (offset))
> > +
Yes, I noticed this, but it would mean this will diverge from
kernel. I can send v2 here and then sync to kernel later.
Regards,
Dhananjay
