Hi Michal,
On Thu, 4 Aug 2022 at 13:36, Michal Suchánek <msucha...@suse.de> wrote:
>
> Hello,
>
> On Thu, Aug 04, 2022 at 01:22:57PM -0600, Simon Glass wrote:
> > Hi Michal,
> >
> > On Thu, 4 Aug 2022 at 11:59, Michal Suchanek <msucha...@suse.de> wrote:
> > >
> > > When probing a device fails NULL pointer is returned, and other devices
> > > cannot be iterated. Skip to next device on error instead.
> > >
> > > Fixes: 6494d708bf ("dm: Add base driver model support")
> > > Signed-off-by: Michal Suchanek <msucha...@suse.de>
> > > ---
> > > drivers/core/uclass.c | 30 +++++++++++++++++++++---------
> > > 1 file changed, 21 insertions(+), 9 deletions(-)
> >
> > Are you able to create a test for this, e.g. in test/dm/core.c or
> > test-fdt.c ?
> >
> > Some sandbox devices can be made to give an error, so the test can
> > check the logic.
> >
> > Strangely enough, this is actually a very big change, so we need to be
> > careful.
>
> Right, I can have a look at doing some tests.
>
> Knowing what the problem is designig a test should not be too difficult.
>
> It does not make the change any smaller but it can at least prevent
> regressions.
>
> Not sure when I get to it, though.
It's pretty easy. But we cannot make any significant change to driver
model without sandbox tests. It is a core system with the potential to
break a lot of boards.
Regards,
Simon
