Hi Stanley, On Tue, 22 Mar 2022 at 21:06, Stanley Chu <[email protected]> wrote: > > Add Nuvoton BMC NPCM845 Pinmux and Pinconf support. > > Signed-off-by: Stanley Chu <[email protected]> > --- > v3: > - separate group names and function names in different tables > to allow for adding additional functions > v2: > - drop the WDnRCRB/CORSTCB register access, it is not for > GPIO modules reset control > --- > drivers/pinctrl/Kconfig | 1 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/nuvoton/Kconfig | 6 + > drivers/pinctrl/nuvoton/Makefile | 1 + > drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c | 1185 +++++++++++++++++++++ > 5 files changed, 1194 insertions(+) > create mode 100644 drivers/pinctrl/nuvoton/Kconfig > create mode 100644 drivers/pinctrl/nuvoton/Makefile > create mode 100644 drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
Reviewed-by: Simon Glass <[email protected]> But please make sure your 'structs' are fully commented and add some more detail to the Kconfig help. Regards, SImon
