Re: [PATCH] Subject: [patch]SPI: GD SPI: Add Gigadevice SPI NOR part numbers

[Michal Simek]

On 11/17/22 01:56, Victor lim wrote:
added gigadevice in the defconfig file and ID in the ids.c file

Signed-off-by: Victor Lim <v...@gigadevice.com>
---
  configs/xilinx_zynqmp_mini_qspi_defconfig |   1 +
  configs/zynq_cse_qspi_defconfig           |   1 +

This should be done in separate patch.

  drivers/mtd/spi/spi-nor-ids.c             | 137 +++++++++++++++-------
  3 files changed, 94 insertions(+), 45 deletions(-)

diff --git a/configs/xilinx_zynqmp_mini_qspi_defconfig 
b/configs/xilinx_zynqmp_mini_qspi_defconfig
index c6401c2a54..75014117f1 100644
--- a/configs/xilinx_zynqmp_mini_qspi_defconfig
+++ b/configs/xilinx_zynqmp_mini_qspi_defconfig
@@ -78,3 +78,4 @@ CONFIG_ZYNQMP_GQSPI=y
  CONFIG_PANIC_HANG=y
  # CONFIG_GZIP is not set
  # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y

This is likely just appended and doesn't reflect Kconfig layout.
Run make xilinx_zynqmp_mini_qspi_defconfig; make savedefconfig; cp defconfig 
configs/xilinx_zynqmp_mini_qspi_defconfig

diff --git a/configs/zynq_cse_qspi_defconfig b/configs/zynq_cse_qspi_defconfig
index 60f0d7cac4..cd245906ab 100644
--- a/configs/zynq_cse_qspi_defconfig
+++ b/configs/zynq_cse_qspi_defconfig
@@ -76,3 +76,4 @@ CONFIG_ARM_DCC=y
  CONFIG_ZYNQ_QSPI=y
  # CONFIG_GZIP is not set
  # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y

ditto. I am also fine with enabling these memories for zynqmp_virt/zynq_virt and 
versal_virt and versal_net_virt platforms.

Hard to guess what you have changed below. But if you want to change style it is 
one patch. If you want to add new devices it is another patch.

Thanks,
Michal