Hi Stefan, Am 13.12.22 um 07:14 schrieb Stefan Roese: > Hi Samuel, > > On 12/13/22 02:46, Samuel Holland wrote: >> On 12/12/22 12:54, Tom Rini wrote: >>> On Sun, Nov 27, 2022 at 11:48:34PM -0600, Samuel Holland wrote: >>> >>>> If the UART bus or baud clock has a gate, it must be enabled before the >>>> UART can be used. >>>> >>>> Signed-off-by: Samuel Holland <sam...@sholland.org> >>>> Reviewed-by: Stefan Roese <s...@denx.de> >>> >>> This breaks building on phycore-rk3288 >> >> I get: >> >> binman: Error 1 running 'mkimage -d ./mkimage.simple-bin.mkimage -n >> rk3288 -T rksd ./idbloader.img': Error: SPL image is too large (size >> 0x8800 than 0x8000) >> >> Before applying this patch: >> >> $ ls -l spl/u-boot-spl.bin >> -rw-r--r-- 1 samuel samuel 32704 Dec 12 19:35 spl/u-boot-spl.bin >> >> So the board was quite close to its SPL size limit already. >> >> I was trying to be general with this patch, but I suppose for my >> immediate purposes (Allwinner D1), I only care about the first clock. If >> I use clk_get_by_index() instead of clk_get_bulk(), the phycore-rk3288 >> build passes with 4 bytes to spare: >> >> $ ls -l spl/u-boot-spl.bin >> -rw-r--r-- 1 samuel samuel 32760 Dec 12 19:36 spl/u-boot-spl.bin >> >> I will send a v2, but I imagine some other unsuspecting patch will run >> into this limit again before long. > > Why not enable LTO to save more space. I just checked this on this > platform: > > w/o LTO: > spl/u-boot-spl.bin 32604 > > with LTO enabled: > spl/u-boot-spl.bin 30016 > > Not tested though.
Thanks for the hint with the LTO. I just send out a patch to enable it for the phycore-rk3288 https://lists.denx.de/pipermail/u-boot/2022-December/502125.html Regards, Wadim > > Thanks, > Stefan