On 1/4/23 19:50, Vlim wrote:
Thanks, Michal,

Thanks for the feedback.

I do have some questions regarding the following comments,

Second. When I run this

for i in `ls configs/xilinx_*`; do NAME=`basename $i`; echo $NAME; make $NAME;
make savedefconfig; cp defconfig $i; done

I see that locations your added entries are not correct.

Third b4 am -g is showing that base is not upstream version.
Please use next branch as base.

Simply base your patches on upstream git repository not u-boot-xlnx.
Use https://source.denx.de/u-boot/u-boot
master or next branch. (next branch is preferred now for upcoming one week or 
so).


Regarding the location of the entry, I believe you want me to add the entry in the alphabetical order?

Not really. I want to you follow Kconfig layout which is what make savedefconfig && cp defconfig configs/<defconfig> is for.


Also, for top posting, I am still not fully understood.
It seems like I should not include the previous email.
Let me try it here see if it is correct.

Just put reaction below things you want to comment as I do here.

Thanks,
Michal

Reply via email to