Hi, Iwamatsu-san,
2011/01/17 19:59, Nobuhiro Iwamatsu wrote:
> Hi, Shimoda-san.
>
> On Mon, Jan 17, 2011 at 01:09:23PM +0900, Yoshihiro Shimoda wrote:
< snip >
>> + val = 0x0;
>
> Is this change necessary?
Oh, this is not necessary.
>> /* Check if full duplex mode is supported by the phy */
>> if (phy_status & (PHY_S_100X_F|PHY_S_10T_F)) {
>> printf("Full\n");
>> - outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>> + outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE|ECMR_DM), ECMR(port));
>> } else {
>> printf("Half\n");
>> - outl((ECMR_CHG_DM|ECMR_RE|ECMR_TE), ECMR(port));
>> + outl(val | (ECMR_CHG_DM|ECMR_RE|ECMR_TE), ECMR(port));
>> }
>
> Is this change necessary?
> Because val is changed to 0 at the top, I do not think that this change is
> necessary.
Thank you for your point.
I will remove it.
Best regards,
Yoshihiro Shimoda
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
