On 1/13/23 19:48, Tom Rini wrote:
On Fri, Jan 13, 2023 at 07:41:51PM +0100, Pali Rohár wrote:
On Friday 13 January 2023 19:25:01 Heinrich Schuchardt wrote:
Downloading files for a test may fail if the server is offline.
It is preferable to provide the files in our Docker image.
Signed-off-by: Heinrich Schuchardt <[email protected]>
---
tools/docker/Dockerfile | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 202a8145af..ee44668ae0 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -213,6 +213,15 @@ RUN git clone https://github.com/stefanberger/swtpm /tmp/swtpm
&& \
make install && \
rm -rf /tmp/swtpm
+# Files to run Nokia RX-51 (aka N900) tests
+RUN mkdir -p /opt/nokia && \
+ cd /opt/nokia && \
+ wget
https://raw.githubusercontent.com/pali/u-boot-maemo/master/debian/u-boot-gen-combined
&& \
This is the link that the Github GUI is offering for download.
If you are downloading it from github then use github.com URI, e.g.:
https://github.com/pali/u-boot-maemo/raw/master/debian/u-boot-gen-combined
This URL is redirected:
$ wget
https://github.com/pali/u-boot-maemo/raw/master/debian/u-boot-gen-combined
--2023-01-13 22:13:38--
https://github.com/pali/u-boot-maemo/raw/master/debian/u-boot-gen-combined
Resolving github.com (github.com)... 140.82.121.4
Connecting to github.com (github.com)|140.82.121.4|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location:
https://raw.githubusercontent.com/pali/u-boot-maemo/master/debian/u-boot-gen-combined
[following]
We should prefer the final URL. The one you suggested seems only to
exist for backwards compatibility.
Best regards
Heinrich
I honestly cannot find something from GitHub itself saying which is
preferred, but I've always done raw.githubusercontent.com instead. We
do mostly (8 times vs 2 times) go the raw.githubusercontent.com path
elsewhere in U-Boot.
