On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_build_message.o > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_common.o > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_spd.o > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_topology.o > > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_mpr_pda_if.o > > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_training.o > > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_training_calibration.o > > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_training_db.o > > +obj-$(CONFIG_SPL_BUILD) += mv_ddr4_training_leveling.o > > obj-$(CONFIG_SPL_BUILD) += xor.o > > And all these new files are ddr4 specific, so should be wrapped in makefile > section: > ifdef CONFIG_DDR4
Looking at the Makefile in question, I think we might want to make the whole thing ifdef CONFIG_SPL_BUILD ... endif and then more finely control building of what objects are built. Perhaps: drivers/Makefile:obj-$(CONFIG_ARMADA_38X) += ddr/marvell/a38x/ should only be for SPL instead, even? -- Tom
signature.asc
Description: PGP signature
