Hi, Wolfgang, 2011/1/19 Jason Liu <liu.h.ja...@gmail.com>: > Hi, Wolfgang, > > 2011/1/19 Wolfgang Denk <w...@denx.de>: >> Dear Jason Liu, >> >> In message <1295382963-32356-1-git-send-email-r64...@freescale.com> you >> wrote: >>> This patch add the MX53 boot image support. >>> >>> This patch has been tested on Freescale MX53EVK board >>> and MX51EVK board. >>> >>> Signed-off-by: Jason Liu <r64...@freescale.com> >>> [snip] >> >>> - Return failure to upper call if met errors for function >>> - Add comments for function set_dcd_rst_v1 alike, >>> - Re-orgnize code to avoid deep nesting, >>> --- >> ... >>> + if ((fhdr_v1->app_code_barker == APP_CODE_BARKER) && >>> + (hdr_v1->dcd_table.preamble.barker == DCD_BARKER)) >>> + >>> + return IMXIMAGE_V1; >>> + >>> + /* Try to detect V2 */ >>> + if ((fhdr_v2->header.tag == IVT_HEADER_TAG) && >>> + (hdr_v2->dcd_table.header.tag == DCD_HEADER_TAG)) >>> + >>> + return IMXIMAGE_V2; >> >> These two need braces. > > Could you please state clear where it need brace? Thanks,
Do you mean the I need add the braces as the following? if ((fhdr_v1->app_code_barker == APP_CODE_BARKER) && (hdr_v1->dcd_table.preamble.barker == DCD_BARKER)) { return IMXIMAGE_V1; } > >> >> Best regards, >> >> Wolfgang Denk >> >> -- >> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de >> Administration: An ingenious abstraction in politics, designed to >> receive the kicks and cuffs due to the premier or president. >> - Ambrose Bierce >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot