Hi Fabio,
On Sat, Jan 28, 2023 at 6:50 PM Fabio Estevam <[email protected]> wrote:
>
> Hi Dario,
>
> On Sat, Jan 28, 2023 at 1:09 PM Dario Binacchi
> <[email protected]> wrote:
> >
> > The Linux kernel device tree already specifies the device to be used for
> > boot console output with a stdout-path property under /chosen.
> >
> > Fixes: 36b661dc919da ("Merge branch 'next'")
>
> The patch looks good, but I don't understand why this needs a Fixes tag.
The patch re-added 'console=${console}':
diff --cc include/configs/imx8mn_bsh_smm_s2.h
index d09c2ab01610,84c19824bdca..c6b296281424
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@@ -14,11 -14,8 +14,9 @@@
#include <config_distro_bootcmd.h>
#define NANDARGS \
- "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
- "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
- "nandargs=setenv bootargs " \
+ "nandargs=setenv bootargs console=${console} " \
"${optargs} " \
+ "mtdparts=${mtdparts} " \
"root=${nandroot} " \
"rootfstype=${nandrootfstype}\0" \
"nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
that I already removed in the commit:
bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs").
This is why I decided to add the fix tag.
Thanks and regards,
Dario
>
> Reviewed-by: Fabio Estevam <[email protected]>
--
Dario Binacchi
Senior Embedded Linux Developer
[email protected]
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
[email protected]
www.amarulasolutions.com
