On 1/28/23 23:01, Simon Glass wrote:
On Fri, 27 Jan 2023 at 17:12, Heinrich Schuchardt
<[email protected]> wrote:

Device name are typically longer than 8 characters. This leads to ragged
output.
Only the I and O bit of the device flags are of interest for the user.
Writing a hexadecimal number is just confusing.

Before the patch the output looked like this:

     => coninfo
     List of available devices:
     pl011@9000000 00000007 IO stdin stdout stderr
     serial   00000003 IO
     usbkbd   00000001 I.

With the patch the output looks like this:

     => coninfo
     List of available devices
     |-- pl011@9000000 (IO)
     |   |-- stdin
     |   |-- stdout
     |   |-- stderr
     |-- serial (IO)
     |-- usbkbd (I)

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
  cmd/console.c | 14 ++++++--------
  1 file changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Simon Glass <[email protected]>

Is there a help update for this?

The online help does not need a change.

But a man-page in the HTML documentation with an example showing reassignment of stdios would be helpful.

In drv_system_init() we create a stdio device called "serial". Do we need this dummy device if CONFIG_$(SPL_TPL_)DM_SERIAL=y? I find this device duplicating the default serial device confusing.

Best regards

Heinrich

Reply via email to