> -----Original Message----- > From: Simon Glass <[email protected]> > Sent: Tuesday, January 24, 2023 2:44 AM > To: Ryan Chen <[email protected]> > Cc: Heiko Schocher <[email protected]>; BMC-SW <[email protected]>; > [email protected] > Subject: Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode > driver > > Hi Ryan, > > On Fri, 20 Jan 2023 at 17:10, Ryan Chen <[email protected]> wrote: > > > > > -----Original Message----- > > > From: Simon Glass <[email protected]> > > > Sent: Saturday, January 21, 2023 5:58 AM > > > To: Ryan Chen <[email protected]> > > > Cc: Heiko Schocher <[email protected]>; BMC-SW > <[email protected]>; > > > [email protected] > > > Subject: Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new > > > register mode driver > > > > > > Hi Ryan, > > > > > > On Thu, 19 Jan 2023 at 20:12, Ryan Chen <[email protected]> > > > wrote: > > > > > > > > Hello Simon, > > > > Sorry, do you have time to check v2 patch? > > > > > > I did not see a change log on it, so was not sure anything was needed? > > > Were there changes from the previous version? > > > > There have cover latter [PATCH v2 0/1] > > https://www.mail-archive.com/[email protected]/msg460560.html > > You can use patman to produce a change list on each patch, then collate the > change lists into the cover letter. That way it is easier to put it on the > patch, > which is where I would expect it, while still having the cover letter show all > changes. > > It looks OK to me..but re this one: > > ret = uclass_get_device_by_driver(UCLASS_MISC, > + > DM_DRIVER_GET(aspeed_i2c_global), > + &global_dev); > > Can you not use the parent device? Hello Simon, Thanks your advice. I modify it use function ofnode_get_parent to get parent node address. And send the PATCHv3 https://www.mail-archive.com/[email protected]/msg462840.html
> > Regards, > Simon
