On Thu, Feb 16, 2023 at 04:08:59PM +0100, Heinrich Schuchardt wrote:

> Some boards provide main U-Boot as a dedicated partition to SPL.
> Currently we can define either a fixed partition number or an MBR
> partition type to define which partition is to be used.
> 
> Partition numbers tend to conflict with established partitioning schemes
> of Linux distros. MBR partitioning is more and more replaced by GPT
> partitioning.
> 
> Allow defining a partition type GUID identifying the partition to load
> main U-Boot from.
> 
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
>  common/spl/Kconfig   | 33 +++++++++++++++++++++++++++------
>  common/spl/spl_mmc.c | 13 +++++++++++++
>  2 files changed, 40 insertions(+), 6 deletions(-)
> 
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 3c2af453ab..29166d8b98 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -513,20 +513,41 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
>         Partition on the MMC to load U-Boot from when the MMC is being
>         used in raw mode
>  
> +if SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
> +
>  config SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE
> -     bool "MMC raw mode: by partition type"
> -     depends on DOS_PARTITION && SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION

I don't like using "if" to hide Kconfig options and feel that we should
use it when a large number (double digits perhaps?) of options aren't
allowed without the symbol, please just use depends on
SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION for the new option here.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to