Dear Tom Warren,
In message <1295651217-32421-2-git-send-email-twar...@nvidia.com> you wrote:
> Signed-off-by: Tom Warren <twar...@nvidia.com>
>...
...
> +/* Clock/Reset Controller (CLK_RST_CONTROLLER_) regs */
> +typedef volatile struct clk_rst_ctlr {
...
> +/* APB MISC Pin Mux and Tristate (APB_MISC_PP_) registers */
> +typedef volatile struct pinmux_tri_ctlr {
...
> +/* Power Management Controller (APBDEV_PMC_) registers */
> +typedef volatile struct pmc_ctlr {
...
> +#ifndef __ASSEMBLY__
> +typedef volatile struct timerus {
> + unsigned int cntr_1us;
> +} timerus_t;
...
> +/* UART registers */
> +typedef volatile struct uart_ctlr {
Please drop the "typedef" and the "volatile" from all these (and all
other, similar) declarations.
See linux/Documentation/CodingStyle:
It's a _mistake_ to use typedef for structures and pointers.
See Documentation/volatile-considered-harmful.txt
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I am a computer. I am dumber than any human and smarter than any ad-
ministrator.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
