Am Di., 11. Apr. 2023 um 16:29 Uhr schrieb Bin Meng <[email protected]>: > > On Tue, Apr 11, 2023 at 10:25 PM Christian Gmeiner > <[email protected]> wrote: > > > > The non DM code path already would enable pci bus mastering. Do the > > same for the DM code path. > > > > Fixes AHCI problems I am seeing on an Intel Apollolake device. > > > > v2: Add Bin's R-b and remove the ending '.' from comment. > > The changelog should go below --- otherwise it shows up in the commit message > :) >
Yeah .. I had that feeling to put it there but .. I will give it another try :) > > > > Signed-off-by: Christian Gmeiner <[email protected]> > > Reviewed-by: Bin Meng <[email protected]> > > --- > > drivers/ata/ahci.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > > index 6998b82aa5..360ac2c060 100644 > > --- a/drivers/ata/ahci.c > > +++ b/drivers/ata/ahci.c > > @@ -1152,7 +1152,12 @@ int ahci_probe_scsi(struct udevice *ahci_dev, ulong > > base) > > int ahci_probe_scsi_pci(struct udevice *ahci_dev) > > { > > ulong base; > > - u16 vendor, device; > > + u16 vendor, device, cmd; > > + > > + /* Enable bus mastering */ > > + dm_pci_read_config16(dev, PCI_COMMAND, &cmd); > > + cmd |= PCI_COMMAND_MASTER; > > + dm_pci_write_config16(dev, PCI_COMMAND, cmd); > > > > base = (ulong)dm_pci_map_bar(ahci_dev, PCI_BASE_ADDRESS_5, 0, 0, > > PCI_REGION_TYPE, PCI_REGION_MEM); > > Regards, > Bin -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy
