On 14:45-20230417, Roger Quadros wrote: [...] > >>> &main_pmx0 { > >>> main_mmc1_pins_default: main-mmc1-pins-default { > >>> + /* XXX: Kernel-Upstream: TODO: Upstream (pull changes) */ > >> > >> Do we really want to sprinkle these comments in u-boot upstream? > > > > I have no other means to indicate that these nodes need to get to > > upstream kernel and when they do get into upstream kernel, what needs to > > be dropped from u-boot. > > > > I am open to suggestions here. > > > >> If we are quite sure this makes to upstream kernel we might as well pull > >> them into > >> u-boot as is. > > > > No, that has been the reason why the entire dt mismatch occurred in the > > first place. the subjective evaluation from various devs have been way > > off. if it makes it to kernel.org master, only then can we claim that > > the changes are in upstream. > > In that case we do not accept any DT patches in u-boot till at least > Acked by kernel maintainer? My 2 cents: Given that: a) until the maintainer sends a tag to upstream merge, things are'nt really final and patches still have been dropped and/or modified (not typically, but have happened) b) the delay between a tag and final merge is just a few weeks
We should hold the master tag as baseline at least till things settle down, prior to relaxing rules to what is reasonable. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D