On Wed, 19 Apr 2023 at 22:11, Rasmus Villemoes <[email protected]> wrote: > > By the time we jump to the err label, count represents the number of > gpios we've succesfully requested. So by subtracting one, we fail to > free the most recently requested. > > Signed-off-by: Rasmus Villemoes <[email protected]> > --- > drivers/gpio/gpio-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <[email protected]> Could the tests catch this bug? > > diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c > index c8be5a4d66..712119c341 100644 > --- a/drivers/gpio/gpio-uclass.c > +++ b/drivers/gpio/gpio-uclass.c > @@ -1219,7 +1219,7 @@ int gpio_request_list_by_name_nodev(ofnode node, const > char *list_name, > return count; > > err: > - gpio_free_list_nodev(desc, count - 1); > + gpio_free_list_nodev(desc, count); > > return ret; > } > -- > 2.37.2 >
