Dear Simon Glass,
In message <[email protected]> you wrote:
> Driver originally written by NVIDIA Corporation, modified to
> handle odd-length packets.
>
> Signed-off-by: Simon Glass <[email protected]>
> ---
> drivers/usb/eth/Makefile | 3 +
> drivers/usb/eth/asix.c | 633
> +++++++++++++++++++++++++++++++++++++++++++
> drivers/usb/eth/usb_ether.c | 7 +
> include/usb_ether.h | 7 +
> 4 files changed, 650 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/eth/asix.c
...
> +/*
> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
> + * See file CREDITS for list of people who contributed to this
> + * project.
Please drop the "All rights reserved." clause which might be
incompatible with the GPL.
> +/**
> + * Asix infrastructure commands
> + */
> +static int asix_write_cmd(struct ueth_data *dev, u8 cmd, u16 value, u16
> index,
Incorrect multiline comment style. Please fix globally.
> +static inline int asix_set_sw_mii(struct ueth_data *dev)
> +{
> + int ret;
> + ret = asix_write_cmd(dev, AX_CMD_SET_SW_MII, 0x0000, 0, 0, NULL);
Please insert blank line after declarations. Please fix globally.
> + if (ret < 0)
> + debug("Failed to write Medium Mode mode to 0x%04x: %02x\n",
> + mode, ret);
Braces needed for multiline statement.
> + if (ret < 0)
> + debug("Failed to write RX_CTL mode to 0x%04x: %02x\n",
> + mode, ret);
Ditto. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
Prepare for tomorrow -- get ready.
-- Edith Keeler, "The City On the Edge of Forever",
stardate unknown
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
