The MMC_CMD_STOP_TRANSMISSION response is R1 for read transfers
per JEDEC Standard No. 84-B51 Page 126 . Correct the response
type and add a comment about it.

Signed-off-by: Marek Vasut <[email protected]>
---
V2: New patch
---
Cc: "Ying-Chun Liu (PaulLiu)" <[email protected]>
Cc: Hai Pham <[email protected]>
Cc: Jaehoon Chung <[email protected]>
Cc: Loic Poulain <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Takeshi Kihara <[email protected]>
---
 drivers/mmc/mmc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 965bc8f0dba..f9b2f940389 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -427,7 +427,12 @@ static int mmc_read_blocks(struct mmc *mmc, void *dst, 
lbaint_t start,
        if (blkcnt > 1) {
                cmd.cmdidx = MMC_CMD_STOP_TRANSMISSION;
                cmd.cmdarg = 0;
-               cmd.resp_type = MMC_RSP_R1b;
+               /*
+                * JEDEC Standard No. 84-B51 Page 126
+                * CMD12 STOP_TRANSMISSION R1/R1b[3]
+                * NOTE 3 R1 for read cases and R1b for write cases.
+                */
+               cmd.resp_type = MMC_RSP_R1;
                if (mmc_send_cmd(mmc, &cmd, NULL)) {
 #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
                        pr_err("mmc fail to send stop cmd\n");
-- 
2.39.2

Reply via email to