Re: [PATCH] spl: spl_legacy: Fix spl_end address

[Tom Rini]

On Fri, Jun 30, 2023 at 08:12:36PM -0300, Fabio Estevam wrote:
> On Fri, Jun 30, 2023 at 6:04 PM Tom Rini <tr...@konsulko.com> wrote:
> 
> > Yeah, just hit re-run when that happens, sadly.
> 
> Ok, only sunxi failed.
> 
> If I try:
> 
> --- a/arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds
> +++ b/arch/arm/cpu/arm926ejs/sunxi/u-boot-spl.lds
> @@ -37,6 +37,8 @@ SECTIONS
>         __image_copy_end = .;
>         _end = .;
> 
> +       _image_binary_end = .;
> +
>         .bss :
>         {
>                 . = ALIGN(4);
> diff --git a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds
> b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds
> index 306a4ddf3cd2..0787dfff8fb7 100644
> --- a/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds
> +++ b/arch/arm/cpu/armv7/sunxi/u-boot-spl.lds
> @@ -46,6 +46,8 @@ SECTIONS
>         __image_copy_end = .;
>         _end = .;
> 
> +       _image_binary_end = .;
> +
>         .bss :
>         {
>                 . = ALIGN(4);
> 
> Then it builds fine.
> 
> I am thinking of sending the sunxi lds change as part of a series in v2.
> 
> So v2 would become:
> 
> 1/2: the sunxi lds change above
> 
> 2/2 the original patch:
> 
> --- a/common/spl/spl_legacy.c
> +++ b/common/spl/spl_legacy.c
> @@ -19,7 +19,7 @@
>  static void spl_parse_legacy_validate(uintptr_t start, uintptr_t size)
>  {
>         uintptr_t spl_start = (uintptr_t)_start;
> -       uintptr_t spl_end = (uintptr_t)__bss_end;
> +       uintptr_t spl_end = (uintptr_t)_image_binary_end;
>         uintptr_t end = start + size;

Sounds good.

-- 
Tom

signature.asc
Description: PGP signature