Hi Simon, On Sun, Jul 16, 2023 at 11:40 AM Simon Glass <[email protected]> wrote: > > A hex value is expected for the VGA mode. Add a 0x prefix, since the # > construct is not supported in SPL. We don't want to add it, due to > code-size constraints. > > Signed-off-by: Simon Glass <[email protected]> > --- > > (no changes since v1) > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c > index 0b5c7e5ab4d6..fe85c7ee3e08 100644 > --- a/drivers/pci/pci_rom.c > +++ b/drivers/pci/pci_rom.c > @@ -278,7 +278,7 @@ int dm_pci_run_vga_bios(struct udevice *dev, int > (*int15_handler)(void), > defined(CONFIG_FRAMEBUFFER_VESA_MODE) > vesa_mode = CONFIG_FRAMEBUFFER_VESA_MODE; > #endif > - debug("Selected vesa mode %#x\n", vesa_mode); > + debug("Selected vesa mode 0x%x\n", vesa_mode); > > if (exec_method & PCI_ROM_USE_NATIVE) { > #ifdef CONFIG_X86 > @@ -329,7 +329,7 @@ int dm_pci_run_vga_bios(struct udevice *dev, int > (*int15_handler)(void), > log_debug("done\n"); > #endif > } > - debug("Final vesa mode %#x\n", mode_info.video_mode); > + debug("Final vesa mode %x\n", mode_info.video_mode);
Missing adding "0x" here? > ret = 0; > > err: > -- Reviewed-by: Bin Meng <[email protected]>
