Hi Svyatoslav, On Sun, 23 Jul 2023 at 06:28, Svyatoslav Ryhel <[email protected]> wrote: > > The driver provides regulator set/get voltage enable/disable > functions for TI TPS80031/TPS80032 PMICs. > > Signed-off-by: Svyatoslav Ryhel <[email protected]> > --- > drivers/power/regulator/Kconfig | 8 + > drivers/power/regulator/Makefile | 1 + > drivers/power/regulator/tps80031_regulator.c | 296 +++++++++++++++++++ > 3 files changed, 305 insertions(+) > create mode 100644 drivers/power/regulator/tps80031_regulator.c
Reviewed-by: Simon Glass <[email protected]> This is quite nice code. Consider the 'p' suffix for return vars and also the meaning of 'hex'. Regards, Simon

