On Fri, Aug 04, 2023 at 07:04:48PM +0800, Macpaul Lin wrote: > From: Fabien Parent <[email protected]> > > Add mt8195-demo board support. > This demo purpose board uses MediaTek's MT8195 SoC. > > Signed-off-by: Fabien Parent <[email protected]> > Signed-off-by: Amjad Ouled-Ameur <[email protected]> > Signed-off-by: Macpaul Lin <[email protected]> [snip] > diff --git a/board/mediatek/mt8195/MAINTAINERS > b/board/mediatek/mt8195/MAINTAINERS > new file mode 100644 > index 0000000000..01fa25115d > --- /dev/null > +++ b/board/mediatek/mt8195/MAINTAINERS > @@ -0,0 +1,6 @@ > +MT8195 Demo > +M: Macpaul Lin <[email protected]> > +S: Maintained > +F: board/mediatek/mt8195 > +F: include/configs/mt8195.h > +F: configs/mt8195_demo_defconfig
Please list the dts files here too, and these are being synced with Linux, yes? [snip] > diff --git a/include/configs/mt8195.h b/include/configs/mt8195.h > new file mode 100644 > index 0000000000..7af06da6ea > --- /dev/null > +++ b/include/configs/mt8195.h > @@ -0,0 +1,46 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Configuration for MT8195 based boards > + * > + * Copyright (C) 2023 MediaTek Inc. > + * Copyright (C) 2023 BayLibre, SAS > + * Author: Macpaul Lin <[email protected]> > + * Author: Fabien Parent <[email protected]> > + */ > + > +#ifndef __MT8195_H > +#define __MT8195_H > + > +#include <linux/sizes.h> Drop this, especially as there was just some time spent fixing "need <linux/size.h> in a generic header" mediatek code. > +/* Environment settings */ > +#include <config_distro_bootcmd.h> > + > +#if IS_ENABLED(CONFIG_CMD_MMC) > +#define BOOT_TARGET_MMC(func) func(MMC, mmc, 0) > +#else > +#define BOOT_TARGET_MMC(func) > +#endif > + > +#if IS_ENABLED(CONFIG_CMD_USB) > +#define BOOT_TARGET_USB(func) func(USB, usb, 0) > +#else > +#define BOOT_TARGET_USB(func) > +#endif > + > +#define BOOT_TARGET_DEVICES(func) \ > + BOOT_TARGET_MMC(func) \ > + BOOT_TARGET_USB(func) > + > +#if !defined(CFG_EXTRA_ENV_SETTINGS) > +#define CFG_EXTRA_ENV_SETTINGS \ > + "scriptaddr=0x40000000\0" \ > + "fdt_addr_r=0x44000000\0" \ > + "fdtoverlay_addr_r=0x44c00000\0" \ > + "kernel_addr_r=0x45000000\0" \ > + "ramdisk_addr_r=0x46000000\0" \ > + "fdtfile=" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \ > + BOOTENV > +#endif Please look at moving to plain text environment, thanks. -- Tom
signature.asc
Description: PGP signature
