hi Simon, On Thu, 10 Aug 2023 at 22:57, Simon Glass <[email protected]> wrote: > > Hi, > > On Thu, 10 Aug 2023 at 09:52, Tom Rini <[email protected]> wrote: > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > > will be used subsequently for testing capsule generation in binman. > > > > > > Signed-off-by: Sughosh Ganu <[email protected]> > > > --- > > > Changes since V7: None > > > > > > tools/Kconfig | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > index 6e23f44d55..353a855243 100644 > > > --- a/tools/Kconfig > > > +++ b/tools/Kconfig > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > Enable SHA512 support in the tools builds > > > > > > config TOOLS_MKEFICAPSULE > > > - bool "Build efimkcapsule command" > > > - default y if EFI_CAPSULE_ON_DISK > > > + bool "Build mkeficapsule tool" > > > + default y if EFI_CAPSULE_ON_DISK || SANDBOX > > > help > > > - This command allows users to create a UEFI capsule file and, > > > + This tool allows users to create a UEFI capsule file and, > > > optionally sign that file. If you want to enable UEFI capsule > > > update feature on your target, you certainly need this. > > > > Sorry, what is this fixing exactly? > > s/command/tool/ is mixed in with this commit, but the main purpose is > to enable it on sandbox.
Sorry, I did not understand this statement. The changes made here are using the same nomenclature(tool) for referring to mkeficapsule. > > The commit message really should mention both changes. Which two changes? The commit message states what the commit is doing, and then states the reason for the change. What more information is needed in the commit message? -sughosh
