On sam., août 19, 2023 at 16:23, Marek Vasut <[email protected]> wrote:

> Convert to plain udevice interaction with UDC controller
> device, avoid the use of UDC uclass dev_array .
>
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: Angus Ainslie <[email protected]>
> Cc: Dmitrii Merkurev <[email protected]>
> Cc: Eddie Cai <[email protected]>
> Cc: Kever Yang <[email protected]>
> Cc: Lukasz Majewski <[email protected]>
> Cc: Miquel Raynal <[email protected]>
> Cc: Mattijs Korpershoek <[email protected]>
> Cc: Nishanth Menon <[email protected]>
> Cc: Patrice Chotard <[email protected]>
> Cc: Patrick Delaunay <[email protected]>
> Cc: Philipp Tomsich <[email protected]>
> Cc: Simon Glass <[email protected]>
> Cc: Stefan Roese <[email protected]>
> Cc: [email protected]
> ---
>  cmd/fastboot.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Tested that I could reflash the bootloader (raw) partition with:

$ fastboot flash bootloader u-boot_kvim3_noab.bin

Works fine!

Reviewed-by: Mattijs Korpershoek <[email protected]>
Tested-by: Mattijs Korpershoek <[email protected]> # on khadas vim3

Based on: 2023.10-rc3

>
> diff --git a/cmd/fastboot.c b/cmd/fastboot.c
> index 3d5ff951eb6..17fb0a0aa7b 100644
> --- a/cmd/fastboot.c
> +++ b/cmd/fastboot.c
> @@ -61,6 +61,7 @@ static int do_fastboot_usb(int argc, char *const argv[],
>  {
>       int controller_index;
>       char *usb_controller;
> +     struct udevice *udc;
>       char *endp;
>       int ret;
>  
> @@ -79,7 +80,7 @@ static int do_fastboot_usb(int argc, char *const argv[],
>               return CMD_RET_FAILURE;
>       }
>  
> -     ret = usb_gadget_initialize(controller_index);
> +     ret = udc_device_get_by_index(controller_index, &udc);
>       if (ret) {
>               pr_err("USB init failed: %d\n", ret);
>               return CMD_RET_FAILURE;
> @@ -103,13 +104,13 @@ static int do_fastboot_usb(int argc, char *const argv[],
>               if (ctrlc())
>                       break;
>               schedule();
> -             usb_gadget_handle_interrupts(controller_index);
> +             dm_usb_gadget_handle_interrupts(udc);
>       }
>  
>       ret = CMD_RET_SUCCESS;
>  
>  exit:
> -     usb_gadget_release(controller_index);
> +     udc_device_put(udc);
>       g_dnl_unregister();
>       g_dnl_clear_detach();
>  
> -- 
> 2.40.1

Reply via email to