On ven., sept. 01, 2023 at 11:49, Marek Vasut <[email protected]> wrote:

> Move the variable declaration around to improve code readability.
> No functional change.
>
> Signed-off-by: Marek Vasut <[email protected]>

Reviewed-by: Mattijs Korpershoek <[email protected]>

> ---
> Cc: Angus Ainslie <[email protected]>
> Cc: Dmitrii Merkurev <[email protected]>
> Cc: Eddie Cai <[email protected]>
> Cc: Kever Yang <[email protected]>
> Cc: Lukasz Majewski <[email protected]>
> Cc: Miquel Raynal <[email protected]>
> Cc: Mattijs Korpershoek <[email protected]>
> Cc: Nishanth Menon <[email protected]>
> Cc: Patrice Chotard <[email protected]>
> Cc: Patrick Delaunay <[email protected]>
> Cc: Philipp Tomsich <[email protected]>
> Cc: Simon Glass <[email protected]>
> Cc: Stefan Roese <[email protected]>
> Cc: [email protected]
> ---
> V2: No change
> ---
>  cmd/thordown.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/cmd/thordown.c b/cmd/thordown.c
> index 838764ccef7..0d8dcee5314 100644
> --- a/cmd/thordown.c
> +++ b/cmd/thordown.c
> @@ -15,22 +15,23 @@
>  
>  int do_thor_down(struct cmd_tbl *cmdtp, int flag, int argc, char *const 
> argv[])
>  {
> +     char *interface, *devstring;
> +     int controller_index;
> +     int ret;
> +
>       if (argc < 4)
>               return CMD_RET_USAGE;
>  
> -     char *usb_controller = argv[1];
> -     char *interface = argv[2];
> -     char *devstring = argv[3];
> -
> -     int ret;
> -
>       puts("TIZEN \"THOR\" Downloader\n");
>  
> +     interface = argv[2];
> +     devstring = argv[3];
> +
>       ret = dfu_init_env_entities(interface, devstring);
>       if (ret)
>               goto done;
>  
> -     int controller_index = simple_strtoul(usb_controller, NULL, 0);
> +     controller_index = simple_strtoul(argv[1], NULL, 0);
>       ret = usb_gadget_initialize(controller_index);
>       if (ret) {
>               pr_err("USB init failed: %d\n", ret);
> -- 
> 2.40.1

Reply via email to