Reinhard, On Thu, Feb 24, 2011 at 8:02 PM, Reinhard Meyer <u-b...@emk-elektronik.de> wrote: > Dear matt.wad...@linaro.org, >> From: Matt Waddel<matt.wad...@linaro.org> >> >> These patches add support for the ARM PrimeCell PL180 MultiMedia Interface. >> The Versatile Express was the test platform for these changes. >> >> Matt Waddel (3): >> MMC: Max blocks value adjustable >> MMC: Add support for PL180 ARM mmc device >> ARMV7: Vexpress: Add MMC support >> >> board/armltd/vexpress/ca9x4_ct_vxp.c | 9 + >> drivers/mmc/Makefile | 1 + >> drivers/mmc/mmc.c | 19 +- >> drivers/mmc/mmci.c | 452 >> ++++++++++++++++++++++++++++++++++ >> drivers/mmc/mmci.h | 181 ++++++++++++++ > > I would expect something more descriptive like <hardware>_mmc.[ch] here. > mmci.[ch] does not lead one to think its a hardware specific driver, even > less for > what specific hardware it is. > The same is true for the exported function name "mmci_init", the macro > CONFIG_MMCI etc. The file in the linux kernel is mmci.c. One could argue that keeping it the same as the kernel is a good thing. If it needs to be changed, I would vote for arm_mmci.c.
The config option in the kernel is CONFIG_MMC_ARMMMCI so I would vote for that as the config option in u-boot. br, John _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
