On 20:29-20230911, Kumar, Udit wrote:
> Thank you for suggestion Nishanth
> 
> On 9/11/2023 6:51 PM, Nishanth Menon wrote:
> > On 16:49-20230911, Udit Kumar wrote:
> > > [..]
> > And maybe expand this patch so that it contains something like the
> > following to prevent this from coming back again elsewhere?
> > 
> > diff --git a/drivers/clk/ti/Kconfig b/drivers/clk/ti/Kconfig
> > index fbcdefd889ae..aff1ba5ab43b 100644
> > --- a/drivers/clk/ti/Kconfig
> > +++ b/drivers/clk/ti/Kconfig
> > @@ -36,7 +36,7 @@ config CLK_TI_MUX
> >   config CLK_TI_SCI
> >     bool "TI System Control Interface (TI SCI) clock driver"
> > -   depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL
> > +   depends on CLK && TI_SCI_PROTOCOL && OF_CONTROL && !CLK_K3
> >     help
> >       This enables the clock driver support over TI System Control Interface
> >       available on some new TI's SoCs. If you wish to use clock resources
> > @@ -44,24 +44,24 @@ config CLK_TI_SCI
> >   [..]
> >   config CLK_K3
> >     bool "Clock support for K3 SoC family of devices"
> > -   depends on CLK
> > +   depends on CLK && !CLK_TI_SCI
> >     help
> >       Enables the clock translation layer from DT to device clocks.
> 
> I think these may end up recursive dependency

Please do the needful, but it is best if the Kconfig enforces this prior
to defconfig updates.
> 
> 
> > diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig
> > index 411c210756a3..9625764b304b 100644
> > --- a/drivers/power/domain/Kconfig
> > +++ b/drivers/power/domain/Kconfig
> > @@ -92,14 +92,14 @@ config TEGRA186_POWER_DOMAIN
> >   config TI_SCI_POWER_DOMAIN
> >     bool "Enable the TI SCI-based power domain driver"
> > -   depends on POWER_DOMAIN && TI_SCI_PROTOCOL
> > +   depends on POWER_DOMAIN && TI_SCI_PROTOCOL && !TI_POWER_DOMAIN
> >     help
> >       Generic power domain implementation for TI devices implementing the
> >       TI SCI protocol.
> >   config TI_POWER_DOMAIN
> >     bool "Enable the TI K3 Power domain driver"
> > -   depends on POWER_DOMAIN && ARCH_K3
> > +   depends on POWER_DOMAIN && ARCH_K3 && !TI_SCI_POWER_DOMAIN
> >     help
> >       Generic power domain implementation for TI K3 devices.
> 
> and these too.
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 
849D 1736 249D

Reply via email to