Hi Maxim, On Tue, 26 Sept 2023 at 03:43, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > add external lwIP library as a git submodule. > Use STABLE-2_2_0_RELEASE tag. > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > --- > .gitmodules | 3 +++ > net/lwip/lwip-external | 1 + > 2 files changed, 4 insertions(+) > create mode 100644 .gitmodules > create mode 160000 net/lwip/lwip-external
I really don't agree with having submodules in U-Boot. It's just a huge hassle that we don't need. We still haven't figured out how to deal with config fragments. If no one else is interested in maintaining this stack within U-Boot and syncing up every now and then, perhaps we should reconsider bringing this into U-Boot? We would never normally accept such a large body of code without even a MAINTAINERS entry. Without a network maintainer, even the integration layer will struggle to keep up and up-revving won't be possible anyway. In any case, if we go with lwip, we should copy in just the code that is needed, unchanged, Regards, Simon
