On Wed, 27 Sep 2023 12:42:52 +0300 Okhunjon Sobirjonov <[email protected]> wrote:
Hi, > When NCAT2 generation model's introduced for t113, > the modification in drivers/mmc/sunxi_mmc.c > > + IS_ENABLED(CONFIG_SUNXI_GEN_NCAT2)) && (sdc_no == 2)) > in struct mmc *sunxi_mmc_init(int sdc_no) seems to have > some negative side effects, meaning enabling 8-bit mode for MMC2. "Some negative side effects" sounds cute, but it actually breaks it ;-) > Paticularly, IS_ENABLED(CONFIG_SUNXI_GEN_NCAT2) > should not be used for D1/T113 > since there is not support for 8-bit mode for MMC2 yet. > Therefore, the solution would be to drop this particular > change entirely. So yeah, that line is just plain wrong, it seems like all the NCAT SoCs we have seen (D1/T113/R329) do no support 8-bit eMMC. So thanks for the heads up, I will remove that line from v2. > Signed-off-by: Okhunjon Sobirjonov <[email protected]> S-o-b:'s are only needed for actual patch submissions, not for comments on the list. Cheers, Andre
