On Thu, Oct 5, 2023 at 6:40 PM <egyszer...@freemail.hu> wrote: > > From: Benjamin Szőke <egyszer...@freemail.hu> > > Take over codes from Techenxion to support mmc autodetect boot for pico-imx7d. > > Signed-off-by: Benjamin Szőke <egyszer...@freemail.hu>
Still not good: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #57: Take over codes from Techenxion to support mmc autodetect boot for pico-imx7d. WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #90: FILE: board/technexion/pico-imx7d/pico-imx7d.c:134: +#if CONFIG_IS_ENABLED(FSL_ESDHC_IMX) CHECK: Unnecessary parentheses around 'autodetect_str != NULL' #95: FILE: board/technexion/pico-imx7d/pico-imx7d.c:139: + if ((autodetect_str != NULL) && + (strcmp(autodetect_str, "yes") == 0)) { CHECK: Comparison to NULL could be written "autodetect_str" #95: FILE: board/technexion/pico-imx7d/pico-imx7d.c:139: + if ((autodetect_str != NULL) && CHECK: Alignment should match open parenthesis #96: FILE: board/technexion/pico-imx7d/pico-imx7d.c:140: + if ((autodetect_str != NULL) && + (strcmp(autodetect_str, "yes") == 0)) { ERROR: switch and case should be at the same indent #111: FILE: board/technexion/pico-imx7d/pico-imx7d.c:155: + switch (get_boot_device()) { + case SD3_BOOT: + case MMC3_BOOT: [...] + case SD1_BOOT: [...] + default: ERROR: trailing whitespace #127: FILE: board/technexion/pico-imx7d/pico-imx7d.c:171: +^I$ WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #140: FILE: board/technexion/pico-imx7d/pico-imx7d.c:224: +#if CONFIG_IS_ENABLED(FSL_ESDHC_IMX) WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible #141: FILE: board/technexion/pico-imx7d/pico-imx7d.c:225: +#if defined(CONFIG_ENV_IS_IN_MMC) || defined(CONFIG_ENV_IS_NOWHERE) WARNING: Move const after static - use 'static const iomux_v3_cfg_t' #178: FILE: board/technexion/pico-imx7d/spl.c:165: +static iomux_v3_cfg_t const usdhc1_pads[] = { WARNING: Move const after static - use 'static const iomux_v3_cfg_t' #189: FILE: board/technexion/pico-imx7d/spl.c:176: +static iomux_v3_cfg_t const usdhc3_emmc_pads[] = { CHECK: Lines should not end with a '(' #238: FILE: board/technexion/pico-imx7d/spl.c:225: + imx_iomux_v3_setup_multiple_pads( CHECK: Lines should not end with a '(' #242: FILE: board/technexion/pico-imx7d/spl.c:229: + imx_iomux_v3_setup_multiple_pads( ERROR: switch and case should be at the same indent #246: FILE: board/technexion/pico-imx7d/spl.c:233: + switch (get_boot_device()) { + case SD1_BOOT: [...] + case MMC3_BOOT: [...] + case SD3_BOOT: + default: total: 3 errors, 6 warnings, 5 checks, 220 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile