Hi Sebastian,

On 27.07.23 10:33, Sébastien Szymanski wrote:
Add support for DWC EQoS MAC on i.MX93.

Signed-off-by: Sébastien Szymanski <[email protected]>
---
  drivers/net/dwc_eth_qos.c     | 4 ++++
  drivers/net/dwc_eth_qos_imx.c | 3 +++
  2 files changed, 7 insertions(+)

diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 1e92bd9ca9c0..f70f8afe5831 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -1717,6 +1717,10 @@ static const struct udevice_id eqos_ids[] = {
                .compatible = "nxp,imx8mp-dwmac-eqos",
                .data = (ulong)&eqos_imx_config
        },
+       {
+               .compatible = "nxp,imx93-dwmac-eqos",
+               .data = (ulong)&eqos_imx_config
+       },
  #endif
#if IS_ENABLED(CONFIG_DWC_ETH_QOS_QCOM)
diff --git a/drivers/net/dwc_eth_qos_imx.c b/drivers/net/dwc_eth_qos_imx.c
index 60f3f3f5a10f..e3f55dd98173 100644
--- a/drivers/net/dwc_eth_qos_imx.c
+++ b/drivers/net/dwc_eth_qos_imx.c
@@ -181,6 +181,9 @@ static int eqos_set_tx_clk_speed_imx(struct udevice *dev)
        ulong rate;
        int ret;
+ if (device_is_compatible(dev, "nxp,imx93-dwmac-eqos"))
+               return 0;
+
        debug("%s(dev=%p):\n", __func__, dev);
if (eqos->phy->interface == PHY_INTERFACE_MODE_RMII)

Your series breaks Rockchip's boards. For example:

+aarch64-linux-ld.bfd: drivers/net/dwc_eth_qos.o:(.rodata.eqos_ids+0x28): undefined reference to `eqos_imx_config'
+make[1]: *** [Makefile:1765: u-boot] Error 1
+make: *** [Makefile:177: sub-make] Error 2
   aarch64:  w+   rock-4c-plus-rk3399

But it is just an example, quite all boards are broken. Please check this and repost, thanks !

Best regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================

Reply via email to