On Mon, 17 Jul 2023 15:29:20 -0400
Tom Rini <tr...@konsulko.com> wrote:
Hi Tom,
> When building this with clang, we get a warning about having excess
> parenthesis here, or that we're incorrectly using "==" when we want "=".
> Correct these by using parenthesis around our multiplication of
> constants as this is what was likely intended originally, even if not
> strictly required.
thanks, I will take this with SZ_512M, as Simon suggested.
Will be part of the next PR.
Cheers,
Andre
>
> Signed-off-by: Tom Rini <tr...@konsulko.com>
> ---
> Cc: Andre Przywara <andre.przyw...@arm.com>
> ---
> board/sunxi/board.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index f321cd58a6e6..643e8db185b4 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -957,7 +957,7 @@ int board_fit_config_name_match(const char *name)
> #ifdef CONFIG_PINE64_DT_SELECTION
> if (strstr(best_dt_name, "-pine64-plus")) {
> /* Differentiate the Pine A64 boards by their DRAM size. */
> - if ((gd->ram_size == 512 * 1024 * 1024))
> + if (gd->ram_size == (512 * 1024 * 1024))
> best_dt_name = "sun50i-a64-pine64";
> }
> #endif
