On Fri, Dec 8, 2023 at 12:52 PM Shantur Rathore <i...@shantur.com> wrote:
>
> Hi Jagan,
>
> On Fri, Dec 8, 2023 at 11:13 AM Jagan Teki <ja...@amarulasolutions.com> wrote:
> >
> > On Sun, Nov 19, 2023 at 10:54 PM Shantur Rathore <i...@shantur.com> wrote:
> > >
> > > Rockchip SoCs can support wide range of bootflows.
> > > Without full bootflow commands, it can be difficult to
> > > figure out issues if any, hence enable by default.
> > >
> > > Reviewed-by: Simon Glass <s...@chromium.org>
> > >
> > > Signed-off-by: Shantur Rathore <i...@shantur.com>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >  arch/arm/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > > index d812685c98..fca6ef6d7e 100644
> > > --- a/arch/arm/Kconfig
> > > +++ b/arch/arm/Kconfig
> > > @@ -1986,6 +1986,7 @@ config ARCH_ROCKCHIP
> > >         imply CMD_DM
> > >         imply DEBUG_UART_BOARD_INIT
> > >         imply BOOTSTD_DEFAULTS
> > > +       imply BOOTSTD_FULL if BOOTSTD_DEFAULTS
> >
> > Yes, but better to give this option to specific board vendors as
> > defaults are enough to boot 1st bootflow and what ever media's it has.
> >
>
> Yes, that's correct it is enough to boot but by default there is no option
> to choose what to boot from.
> This was discussed in an earlier version of this patch [0] where I was
> explicitly enabling only for RP64.

What actual extra functionality does this provide, what is the impact
on the size of images? You've not provided reasonable justification
outside of very vague statements, it would be useful to know what the
added options actually solves.

Reply via email to