чт, 28 груд. 2023 р. о 21:48 Simon Glass <s...@chromium.org> пише: > > On Thu, Dec 28, 2023 at 6:02 PM Svyatoslav Ryhel <clamo...@gmail.com> wrote: > > > > From: Ion Agorria <i...@agorria.com> > > > > Set flag to enable console record on console_record_init > > and not only on console_record_reset_enable. This fixes > > missing start of U-Boot log for fastboot oem console > > command. > > > > Signed-off-by: Ion Agorria <i...@agorria.com> > > Signed-off-by: Svyatoslav Ryhel <clamo...@gmail.com> > > Reviewed-by: Mattijs Korpershoek <mkorpersh...@baylibre.com> > > --- > > common/console.c | 3 +++ > > 1 file changed, 3 insertions(+) > > Reviewed-by: Simon Glass <s...@chromium.org> > > OK, I can see the use of this...but I wonder if we can now get rid of > the same line of code from console_record_reset_enable() ? >
Interesting question but let's leave it to a dedicated patch :) Best Regards, Svyatoslav R. > > > > diff --git a/common/console.c b/common/console.c > > index 6f2089caa0..e6d7ebe935 100644 > > --- a/common/console.c > > +++ b/common/console.c > > @@ -821,6 +821,9 @@ int console_record_init(void) > > ret = membuff_new((struct membuff *)&gd->console_in, > > CONFIG_CONSOLE_RECORD_IN_SIZE); > > > > + /* Start recording from the beginning */ > > + gd->flags |= GD_FLG_RECORD; > > + > > return ret; > > } > > > > -- > > 2.40.1 > > > > Regards, > Simon