Hi

On Sat, Jan 6, 2024 at 9:49 AM Michael Nazzareno Trimarchi
<mich...@amarulasolutions.com> wrote:
>
> Hi
>
> Is this code correct?
>
>     if (tcp_seq_num >= initial_data_seq_num &&
>                     store_block(pkt, tcp_seq_num - initial_data_seq_num,
>                                 len) != 0) {
>                         wget_fail("wget: store error\n",
>                                   tcp_seq_num, tcp_ack_num, action);
>                         return;
>                 }
>
> Can not be seq_num wrap around? Another point seems that is not
> guarantee packet reassembly
>

And what happen if you are going to generate out of sequence packet
and with large seq_number on purpose?

I think that lwip has much more sense

Michael

> Michael
>
> On Fri, Jan 5, 2024 at 8:53 PM Fabio Estevam <feste...@gmail.com> wrote:
> >
> > On Fri, Jan 5, 2024 at 4:49 PM Michael Nazzareno Trimarchi
> > <mich...@amarulasolutions.com> wrote:
> >
> > > I was thinking that was lwip integration
> >
> > That's a different issue.
> >
> > If you want to test lwip integration, you can try it from:
> > https://github.com/muvarov/u-boot/tree/master_lwip_test_v10
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> mich...@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> i...@amarulasolutions.com
> www.amarulasolutions.com



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Reply via email to